[
https://issues.apache.org/jira/browse/HDFS-11001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609242#comment-15609242
]
Xiaoyu Yao commented on HDFS-11001:
-----------------------------------
Thanks [~anu] for the clarification, emptyList usage makes sense to me. The
nullList allocated per CommandQueue does not look like a standard fly-weight
pattern. But it is OK for our usage as you explained that we don't expect to
instantiate more than one CommandQueue. With the follow up ticket opened for
removal of NullCommand, I'm +1 the latest patch pending Jenkins.
There is a minor issue you can fix at commit time or later: <p> is updated in
ASF license header around the URL in some of the source code in the latest
patch. I thought it should be the same across but there seems to have some
misses <p> from StorageContainerNodeProtocol.java, NullCommand.java,
package-info.java.
> Ozone:SCM: Add support for registerNode in SCM
> ----------------------------------------------
>
> Key: HDFS-11001
> URL: https://issues.apache.org/jira/browse/HDFS-11001
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-11001-HDFS-7240.001.patch,
> HDFS-11001-HDFS-7240.002.patch, HDFS-11001-HDFS-7240.003.patch
>
>
> Adds support for a datanode registration. Right now SCM relies on Namenode
> for the datanode registration. With this change we will be able to run SCM
> independently if needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
