[
https://issues.apache.org/jira/browse/HDFS-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627210#comment-15627210
]
Anu Engineer edited comment on HDFS-10566 at 11/2/16 12:41 AM:
---------------------------------------------------------------
[~xiaobingo] Thank you submitting the patch. It looks very good overall.
Had a minor comment. Instead of throwing an IOException in {{Datanode.java}},
would it be possible to throw a DiskBalancerException.
You would first need to add a corresponding state in
DiskBalancerException.result enum. Say DATANODE_STATUS_NOT_REGULAR.
Then in the exception we can say something like
{noformat}
throw new DiskBalancerException("Datanode is in special state.
Upgrade/Rollback etc. Disk balancing not permitted.",
DiskBalancerException.Result.DATANODE_STATUS_NOT_REGULAR);
{noformat}
was (Author: anu):
[~xiaobingo] Thank you submitting the patch. It looks very good overall.
Had a minor comment. Instead of throwing an IOException in {{Datanode.java}},
would it be possible to throw an DiskBalancerException.
You would first need to add a corresponding state in
DiskBalancerException.result enum. Say DATANODE_STATUS_NOT_REGULAR.
Then in the exception we can say something like
{noformat}
throw new DiskBalancerException("Datanode is in special state.
Upgrade/Rollback etc. Disk balancing not permitted.",
DiskBalancerException.Result.DATANODE_STATUS_NOT_REGULAR);
{noformat}
> Submit plan request should throw exception if Datanode is in non-REGULAR
> status.
> --------------------------------------------------------------------------------
>
> Key: HDFS-10566
> URL: https://issues.apache.org/jira/browse/HDFS-10566
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Jitendra Nath Pandey
> Assignee: Xiaobing Zhou
> Attachments: HDFS-10566.000.patch
>
>
> If datanode is in non-REGULAR status such as upgrade and rollback etc., it
> might be simpler to just refuse balancing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
