[
https://issues.apache.org/jira/browse/HDFS-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647981#comment-15647981
]
Rakesh R commented on HDFS-11029:
---------------------------------
Thank you [~umamaheswararao] for the important work. I've few comments on the
patch, please take care.
# {{storage movement}} -> could you rephrase this as {{block storage movement}}
# In the BlockStorageMovementAttemptedItems constructor, it would be good to
add a log message about the {{checkTimeout}}, {{selfRetryTimeout}} configured
values for debugging purpose.
# Please make {{private}} class StorageMovementAttemptResultMonitor.
# Can we move the following to the constructor rather than resolving multiple
times.
{code}
long period = Math.min(DEFAULT_RECHECK_INTERVAL, checkTimeout);
{code}
# Can we add debug log message after removal, to get the status of the block
movement completion.
{code}
+ if (!exist) {
+ blockStorageMovementNeeded.add(blockCollectionID);
+ }
+ iter.remove();
{code}
# Just a suggestion to add few java comments about this datastructure
{code}
private final Map<Long, Long> storageMovementAttemptedItems;
{code}
# Please name the {{timerThread}}.
> [SPS]:Provide retry mechanism for the blocks which were failed while moving
> its storage at DNs
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-11029
> URL: https://issues.apache.org/jira/browse/HDFS-11029
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS-10285
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-11029-HDFS-10285-00.patch
>
>
> When DN co-ordinator finds some of blocks associated to trackedID could not
> be moved its storages, due to some errors.Here retry may work in some cases,
> example if target node has no space. Then retry by finding another target can
> work.
> So, based on the movement result flag(SUCCESS/FAILURE) from DN Co-ordinator,
> NN would retry by scanning the blocks again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
