[ https://issues.apache.org/jira/browse/HDFS-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649710#comment-15649710 ]
Brahma Reddy Battula commented on HDFS-9482: -------------------------------------------- [~arpitagarwal] thanks a lot committing to trunk and review.. bq. This was not an easy patch to review and I am sure not very fun to write either. hmm.. Yes, it is not easy..thanks a bunch again for your time on review this. bq.if the only difference in the branch-2 patch is the EC changes then I am +1 for that too. Feel free to commit the branch-2 patch Brahma Reddy Battula. Yes,diff only that ..will commit to branch-2 bq.I posted a comment on HDFS-9371. If we can merge that to branch-2.8 then we don't need a separate branch-2.8 patch here. ok. will hold commit till HDFS-9371 get in branch-2.8. > Replace DatanodeInfo constructors with a builder pattern > -------------------------------------------------------- > > Key: HDFS-9482 > URL: https://issues.apache.org/jira/browse/HDFS-9482 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Brahma Reddy Battula > Assignee: Brahma Reddy Battula > Fix For: 3.0.0-alpha2 > > Attachments: HDFS-9482-002.patch, HDFS-9482-003.patch, > HDFS-9482-branch-2.8.patch, HDFS-9482-branch-2.patch, HDFS-9482.patch > > > As per [~arpitagarwal] comment > [here|https://issues.apache.org/jira/browse/HDFS-9038?focusedCommentId=15018761&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15018761],Replace > DatanodeInfo constructors with a builder pattern, -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org