[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654899#comment-15654899
]
Zhe Zhang commented on HDFS-10872:
----------------------------------
Thanks Erik for the patch! LGTM overall. I think the added
{{newMutableRatesWithAggregation}} constructor is reasonable. Some minors:
# Below change doesn't seem necessary
{code}
- private final MetricsRegistry registry = new MetricsRegistry("FSNamesystem");
+ private final MetricsRegistry registry =
+ new MetricsRegistry("FSNamesystem").setContext("dfs");
{code}
# We could have the @link have its own line, right now the link is broken:
{code}
* If metrics are enabled by setting {@link org.apache.hadoop.hdfs.DFSConfigKeys
* #DFS_NAMENODE_LOCK_DETAILED_METRICS_KEY} to be true, metrics will be emitted
{code}
# Follow-on: maybe we can consider consolidating the code in readUnlock and
writeUnlock
[~andrew.wang] Any further comments? Thanks.
> Add MutableRate metrics for FSNamesystemLock operations
> -------------------------------------------------------
>
> Key: HDFS-10872
> URL: https://issues.apache.org/jira/browse/HDFS-10872
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Attachments: FSLockPerf.java, HDFS-10872.000.patch,
> HDFS-10872.001.patch, HDFS-10872.002.patch, HDFS-10872.003.patch,
> HDFS-10872.004.patch, HDFS-10872.005.patch, HDFS-10872.006.patch
>
>
> Add metrics for FSNamesystemLock operations to see, overall, how long each
> operation is holding the lock for. Use MutableRate metrics for now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
