[
https://issues.apache.org/jira/browse/HDFS-11111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661302#comment-15661302
]
Yuanbo Liu commented on HDFS-11111:
-----------------------------------
[~cltlfcjin]
I'm not a commiter, so I cannot tell you whether this issue should be
addressed, but I agree with the safety option in rm command.
I have quickly went through you PR and have some thoughts about it:
* Please provide patch file instead of PR. I believe your code changes have
check-style/findbugs issues. Using patch file can generate Jenkins report.
* With {{MiniDFSCluster.java}}, it's not necessary to use {{mockFs}} to test
this command.
I will be glad to review your patch again after patch file is uploaded. Thanks
for your contribution to Hadoop.
> Delete something in .Trash using "rm" should be forbidden without safety
> option
> ---------------------------------------------------------------------------------
>
> Key: HDFS-11111
> URL: https://issues.apache.org/jira/browse/HDFS-11111
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 2.7.2
> Reporter: Lantao Jin
> Labels: Incompatible
>
> As we discussed in HDFS-11102, double confirmation does not seem to be a
> graceful solution for users. Deleting files in .Trash accidentally is still
> an issue though. The behaviour of users I'm worried about is {{rm}} ing
> something in .Trash (without explicitly understanding that those files will
> not be recoverable). This is in contrast to {{rm}} ing something with
> "-skipTrash" option (That's a very purposeful action).
> So it is not the same case as HADOOP-12358. The solution is throwing an
> exception and remind user to add "-trash" option to delete dirs in trash for
> safely:
> {code}
> Can not delete somehing trash directly! Please add "-trash" or "-T" in "rm"
> command to do that.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
