[
https://issues.apache.org/jira/browse/HDFS-11135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HDFS-11135:
-----------------------------
Description:
I am making test for HDFS-11051, I found a serious issue: All the tests in
{{TestBalancer}} fails except {{TestBalancer#testBalancerWithKeytabs}}. I saw
there was NPE threw in the method {{TestBalancer#destroy}}. The stack infos:
{code}
java.lang.NullPointerException
at org.apache.hadoop.fs.FileUtil.fullyDeleteContents(FileUtil.java:242)
at org.apache.hadoop.fs.FileUtil.fullyDelete(FileUtil.java:164)
at org.apache.hadoop.fs.FileUtil.fullyDelete(FileUtil.java:135)
at
org.apache.hadoop.hdfs.server.balancer.TestBalancer.destroy(TestBalancer.java:274)
{code}
The related codes:
{code}
@AfterClass
public static void destroy() throws Exception {
if (kdc != null) {
kdc.stop();
}
FileUtil.fullyDelete(baseDir);
KeyStoreTestUtil.cleanupSSLConfig(keystoresDir, sslConfDir);
}
{code}
It seems that the deleted dir {{baseDir}} is only used in
{{TestBalancer#testBalancerWithKeytabs}}, but here we don't do a check and then
it throws the NPE. Finally cause the other tests fails. Since it will run the
test {{TestBalancer#testBalancerWithKeytabs}} and initialize the dir if we do
the whole test {{TesrBalancer}}, and it will runs good. However, it will fails
if we want to run a single test in {{TestBalancer}}.
was:
I am making test for HDFS-11051, I found a serious issue: All the tests in
{{TestBalancer}} fails except {{TestBalancer#testBalancerWithKeytabs}}. I saw
there was NPE threw in the method {{TestBalancer#destroy}}. The stack infos:
{code}
java.lang.NullPointerException
at org.apache.hadoop.fs.FileUtil.fullyDeleteContents(FileUtil.java:242)
at org.apache.hadoop.fs.FileUtil.fullyDelete(FileUtil.java:164)
at org.apache.hadoop.fs.FileUtil.fullyDelete(FileUtil.java:135)
at
org.apache.hadoop.hdfs.server.balancer.TestBalancer.destroy(TestBalancer.java:274)
{code}
It seems that the deleted dir {{baseDir}} is only used in
{{TestBalancer#testBalancerWithKeytabs}}, but here we don't do a check and then
it throws the NPE. Finally cause the other tests fails. Since it will run the
test {{TestBalancer#testBalancerWithKeytabs}} and initialize the dir if we do
the whole test {{TesrBalancer}}, and it will runs good. However, it will fails
if we want to run a single test in {{TestBalancer}}.
> The tests in TestBalancer run fails due to NPE
> ----------------------------------------------
>
> Key: HDFS-11135
> URL: https://issues.apache.org/jira/browse/HDFS-11135
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-11135.001.patch
>
>
> I am making test for HDFS-11051, I found a serious issue: All the tests in
> {{TestBalancer}} fails except {{TestBalancer#testBalancerWithKeytabs}}. I saw
> there was NPE threw in the method {{TestBalancer#destroy}}. The stack infos:
> {code}
> java.lang.NullPointerException
> at org.apache.hadoop.fs.FileUtil.fullyDeleteContents(FileUtil.java:242)
> at org.apache.hadoop.fs.FileUtil.fullyDelete(FileUtil.java:164)
> at org.apache.hadoop.fs.FileUtil.fullyDelete(FileUtil.java:135)
> at
> org.apache.hadoop.hdfs.server.balancer.TestBalancer.destroy(TestBalancer.java:274)
> {code}
> The related codes:
> {code}
> @AfterClass
> public static void destroy() throws Exception {
> if (kdc != null) {
> kdc.stop();
> }
> FileUtil.fullyDelete(baseDir);
> KeyStoreTestUtil.cleanupSSLConfig(keystoresDir, sslConfDir);
> }
> {code}
> It seems that the deleted dir {{baseDir}} is only used in
> {{TestBalancer#testBalancerWithKeytabs}}, but here we don't do a check and
> then it throws the NPE. Finally cause the other tests fails. Since it will
> run the test {{TestBalancer#testBalancerWithKeytabs}} and initialize the dir
> if we do the whole test {{TesrBalancer}}, and it will runs good. However, it
> will fails if we want to run a single test in {{TestBalancer}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
