[
https://issues.apache.org/jira/browse/HDFS-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666130#comment-15666130
]
Rakesh R commented on HDFS-10802:
---------------------------------
{quote}
One suggestion here, instead of mixing up the persistence and API, how about
this JIRA focus on API alone and discuss on API signature more. Let's file
another JIRA for persistence, which could cover the persistence of this items
into FSImage as well?
{quote}
Yes, the patch becomes bigger. +1 for splitting into multiple logical tasks.
[~yuanbo], Thanks for taking care this jira. Few comments on the latest patch.
# Here its verifying API when DFS_STORAGE_POLICY_ENABLED_KEY is false.
{{"Should throw IOException for " + nonExistingFile}} msg is not meaningful,
right? Please change the Assert.fail message to reflect the same.
{code}
try {
336 hdfsAdmin.satisfyStoragePolicy(new Path(file));
337 Assert.fail("Should throw IOException for " + nonExistingFile);
338 } catch (IOException e) {
339 Assert.assertTrue(e.getMessage().contains(String.format(
340 "Failed to satisfy storage policy since %s is set to
false.",
341 DFS_STORAGE_POLICY_ENABLED_KEY)));
342 }
{code}
# Could you please add DEBUG log message abt {{inode.getId()}} tracking id
value in {{BlockManager#satisfyStoragePolicy()}} function. That would help us
in debugging later. Thanks!
# Could you please rephrase the DistributedFileSystem#satisfyStoragePolicy
javadoc like,
{code}
/**
* Set the source path to satisfy storage policy. This API is non-recursive in,
* nature i.e., if the source path is a directory then all the files
immediately
* under the directory would be considered for satisfying the policy and
* the sub-directories if any under this path will be skipped.
*
* @param path The source path referring to either a directory or a file.
* @throws IOException
*/
{code}
# {{TestOfflineEditsViewer.testStored}} test case failure is related, please
take care in your next patch.
> [SPS]: Add satisfyStoragePolicy API in HdfsAdmin
> ------------------------------------------------
>
> Key: HDFS-10802
> URL: https://issues.apache.org/jira/browse/HDFS-10802
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Uma Maheswara Rao G
> Assignee: Yuanbo Liu
> Attachments: HDFS-10802-HDFS-10285.001.patch,
> HDFS-10802-HDFS-10285.002.patch, HDFS-10802-HDFS-10285.003.patch,
> HDFS-10802.001.patch, editsStored
>
>
> This JIRA is to track the work for adding user/admin API for calling to
> satisfyStoragePolicy
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
