[ 
https://issues.apache.org/jira/browse/HDFS-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667343#comment-15667343
 ] 

Yiqun Lin commented on HDFS-11134:
----------------------------------

Thanks [~ajisakaa] for taking a look. This sentence looks confused. It can be 
understanding in two meanings:

1.Just restarting cluster can ensure the leases to be persisted in fsimage, the 
same namenode port is not a necessary condition.
2.Restarting cluster and meanwhile keeping the same namenode port can ensure 
the leased to be persisted in fsimage.

I prefer the first meaning. And if the leases have been persisted, it looks 
strange that we must keep the same port to read these leases. So I think this 
is not a necessary condition. This is just my thought. Thanks!

> Fix bind exceptions in TestRenameWhileOpen and TestPendingInvalidateBlock
> -------------------------------------------------------------------------
>
>                 Key: HDFS-11134
>                 URL: https://issues.apache.org/jira/browse/HDFS-11134
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-11134.001.patch
>
>
> I found two bind exceptions causing the unit tests fails in history Jenkins 
> buildings. One is test {{TestRenameWhileOpen}}, the other one is 
> {{TestPendingInvalidateBlock}}.
> Here are the stack infos of {{TestRenameWhileOpen}}(I can't find the stack 
> infos of {{TestPendingInvalidateBlock}} now since the time of that happened 
> is too early, but I'm sure it has failed due to bind exception.)
> {code}
> java.net.BindException: Problem binding to [localhost:42155] 
> java.net.BindException: Address already in use; For more details see:  
> http://wiki.apache.org/hadoop/BindException
>       at sun.nio.ch.Net.bind0(Native Method)
>       at sun.nio.ch.Net.bind(Net.java:433)
>       at sun.nio.ch.Net.bind(Net.java:425)
>       at 
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
>       at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>       at org.apache.hadoop.ipc.Server.bind(Server.java:535)
>       at org.apache.hadoop.ipc.Server$Listener.<init>(Server.java:919)
>       at org.apache.hadoop.ipc.Server.<init>(Server.java:2667)
>       at org.apache.hadoop.ipc.RPC$Server.<init>(RPC.java:959)
>       at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server.<init>(ProtobufRpcEngine.java:367)
>       at 
> org.apache.hadoop.ipc.ProtobufRpcEngine.getServer(ProtobufRpcEngine.java:342)
>       at org.apache.hadoop.ipc.RPC$Builder.build(RPC.java:801)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.<init>(NameNodeRpcServer.java:434)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.createRpcServer(NameNode.java:796)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:723)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:937)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:916)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1633)
>       at 
> org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:1263)
>       at 
> org.apache.hadoop.hdfs.MiniDFSCluster.configureNameService(MiniDFSCluster.java:1032)
>       at 
> org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:907)
>       at 
> org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:839)
>       at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:491)
>       at 
> org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:450)
>       at 
> org.apache.hadoop.hdfs.TestRenameWhileOpen.testWhileOpenRenameToNonExistentDirectory(TestRenameWhileOpen.java:325)
> {code}
> Here specifying the namenode port is not necessary, is similar to HDFS-11129. 
> And I have run this test many times in my local, it all passed. The same we 
> shuld do for test {{TestPendingInvalidateBlock}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to