[
https://issues.apache.org/jira/browse/HDFS-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669206#comment-15669206
]
Xiaoyu Yao commented on HDFS-11126:
-----------------------------------
The patch looks good to me as well. Just few NITs below. +1 after that is fixed.
*ContainerProtocolCalls.java*
Line 46: “Implementation of all container protocol calls performed by .” Can
you elaborate the missing part after “by”?
*FileUtils.java*
Line 41: NIT: getputFileResponse should be getPutFileResponse
Line 60: getSmallFileResponse -> getGetSmallFileResponse? This looks a bit
strange though.
*ContainerTestHelper.java*
Line 116: Missing java doc for pipeline parameter
> Ozone: Add small file support RPC
> ---------------------------------
>
> Key: HDFS-11126
> URL: https://issues.apache.org/jira/browse/HDFS-11126
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-11126-HDFS-7240.001.patch
>
>
> Add an RPC to send both data and metadata together in one RPC. This is useful
> when we want to read and write small files, say less than 1 MB. This API is
> very useful for ozone and cBlocks (HDFS-11118)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
