[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671496#comment-15671496
]
Anu Engineer commented on HDFS-11138:
-------------------------------------
Thought this might help you, checkstyle warnings:
{noformat}
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/CBlockConfigKeys.java:23:public
class CBlockConfigKeys {:1: Utility classes should not have a public or
default constructor.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/CBlockConfiguration.java:22:public
class CBlockConfiguration extends Configuration {: Missing a Javadoc comment.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/CBlockManager.java:127:
(conf, CBlockClientServerProtocolPB.class,:9: '(' should be on the
previous line.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/exception/CBlockException.java:0::
Missing package-info.java file.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/exception/CBlockException.java:22:public
class CBlockException extends IOException {: Missing a Javadoc comment.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/meta/ContainerDescriptor.java:0::
Missing package-info.java file.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/meta/VolumeDescriptor.java:177:
private String getBlockKey(String volumeName, long blockId) {:37:
'volumeName' hides a field.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/proto/CBlockClientServerProtocol.java:0::
Missing package-info.java file.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/proto/CBlockClientServerProtocol.java:22:public
interface CBlockClientServerProtocol {: Missing a Javadoc comment.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/proto/CBlockServiceProtocol.java:26:/**:
First sentence should end with a period.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/proto/MountVolumeResponse.java:5:public
class MountVolumeResponse {: Missing a Javadoc comment.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/proto/MountVolumeResponse.java:6:
public static final long versionID = 1L;:28: Name 'versionID' must match
pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/protocolPB/CBlockClientServerProtocolPB.java:0::
Missing package-info.java file.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/protocolPB/CBlockClientServerProtocolPB.java:24:@ProtocolInfo(protocolName
=: Missing a Javadoc comment.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/protocolPB/CBlockClientServerProtocolServerSideTranslatorPB.java:30:@InterfaceAudience.Private:
Missing a Javadoc comment.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/protocolPB/CBlockClientServerProtocolServerSideTranslatorPB.java:62:
for (int i=0;i<containers.size();i++) {:22: ';' is not followed by
whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/protocolPB/CBlockClientServerProtocolServerSideTranslatorPB.java:62:
for (int i=0;i<containers.size();i++) {:42: ';' is not followed by
whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/protocolPB/CBlockClientServerProtocolServerSideTranslatorPB.java:63:
CBlockClientServerProtocolProtos.ContainerIDProto.Builder ID =:69:
Name 'ID' must match pattern '^[a-z][a-zA-Z0-9]*$'.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/protocolPB/CBlockServiceProtocolPB.java:24:@ProtocolInfo(protocolName
=: Missing a Javadoc comment.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/protocolPB/CBlockServiceProtocolServerSideTranslatorPB.java:32:@InterfaceAudience.Private:
Missing a Javadoc comment.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/storage/IStorageClient.java:0::
Missing package-info.java file.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/storage/StorageManager.java:21:import
org.apache.hadoop.cblock.CBlockManager;:8: Unused import -
org.apache.hadoop.cblock.CBlockManager.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/TestCBlockServer.java:132:
for (int i = 0;i<volumeNum;i++) {:20: ';' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/TestCBlockServer.java:132:
for (int i = 0;i<volumeNum;i++) {:32: ';' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/TestCBlockServer.java:139:
for (int i = 0;i<volumeNum;i++) {:20: ';' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/TestCBlockServer.java:139:
for (int i = 0;i<volumeNum;i++) {:32: ';' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/TestCBlockServer.java:147:
for (int i = 0;i<volumeNum;i++) {:20: ';' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/TestCBlockServer.java:147:
for (int i = 0;i<volumeNum;i++) {:32: ';' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/util/ContainerLookUpService.java:33:public
class ContainerLookUpService {:1: Utility classes should not have a public or
default constructor.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/util/MockStorageClient.java:22:import
org.apache.hadoop.cblock.util.ContainerLookUpService;:1: Redundant import from
the same package - org.apache.hadoop.cblock.util.ContainerLookUpService.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/util/MockStorageClient.java:35:
static long containerId = -1;:15: Variable 'containerId' must be private and
have accessor methods.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/util/MockStorageClient.java:37:
/**: First sentence should end with a period.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/util/MockStorageClient.java:56:
public void deleteContainer(String containerId) throws IOException {:38:
'containerId' hides a field.
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cblock/util/MockStorageClient.java:67:
public ContainerDescriptor getContainer(String containerId):50: 'containerId'
hides a field.
{noformat}
and one javac warning
{noformat}
[WARNING]
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/cblock/CBlockManager.java:[256,37]
[unchecked] unchecked conversion
{noformat}
> Block Storage : add block storage server
> ----------------------------------------
>
> Key: HDFS-11138
> URL: https://issues.apache.org/jira/browse/HDFS-11138
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-11138-HDFS-7240.001.patch
>
>
> This JIRA adds the skeleton for server side code, which is one of the core
> components in block storage. For performance concerns, the server does not
> handle any actual read/write operation but serving primarily as a meta data
> server. It provides four APIs:
> # create volume : which will call into underlying container layer to allocate
> containers
> # delete volume : delete a specific volume (as well as its containers)
> # info volume : return information of a specific volume
> # list volume : list all volumes
> Note that this is still subject to potentially major changes. Features such
> as persistence are missing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
