[ 
https://issues.apache.org/jira/browse/HDFS-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706196#comment-15706196
 ] 

Virajith Jalaparti commented on HDFS-10675:
-------------------------------------------

One thing that came up in conversations with [~ehiggs] is that 
{{StorageDirectory.root}} can be {{null}} because {{PROVIDED}} storage 
locations will not have any directories associated with them. Hence, we need to 
add checks to {{StorageDirectory}} to make sure we handle this. This would also 
lead to changes in code that call {{StorageDirectory.getRoot}}, 
{{StorageDirectory.getCurrentDir}}, {{StorageDirectory.getVersionFile}} etc. as 
the return value can be {{null}} (if {{StorageDirectory.root}} is {{null}}). 

The proposal to handle this is to change the return type of the above functions 
to {{Optional<File>}}. This will lead to changes in a lot of other places but 
will make it explicit that the return value can be {{null}}. I propose to open 
a new JIRA for this. Any comments on this? [~ehiggs], [~eddyxu], [~zhz]

> Datanode support to read from external stores. 
> -----------------------------------------------
>
>                 Key: HDFS-10675
>                 URL: https://issues.apache.org/jira/browse/HDFS-10675
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Virajith Jalaparti
>         Attachments: HDFS-10675-HDFS-9806.001.patch, 
> HDFS-10675-HDFS-9806.002.patch, HDFS-10675-HDFS-9806.003.patch
>
>
> This JIRA introduces a new {{PROVIDED}} {{StorageType}} to represent external 
> stores, along with enabling the Datanode to read from such stores using a 
> {{ProvidedReplica}} and a {{ProvidedVolume}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to