[
https://issues.apache.org/jira/browse/HDFS-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711140#comment-15711140
]
Andrew Wang commented on HDFS-8630:
-----------------------------------
Hi Surendra, thanks for updating the patch, only really have nits,
* baseTestHttpFSWith, could we convert the isLocalFS early exits to instead use
Assume.assumeFalse ? It's cleaner and more informative.
* baseTestHttpFSWith, can also use assertArrayEquals. Please also add messages
to the asserts for easier debugging in case it fails (and as documentation).
* FSOperations, please move the JSON conversion code to static methods like the
others at the top of the file
WebHDFS.md
* The anchor links are broken, I think incorrectly capitalized
* Although this is not related, could you add param documentation for
"startAfter" as well? Or we can do it in a separate JIRA.
* Need to also define the StoragePolicies schema, see FileStatuses/FileStatus
as an example
> WebHDFS : Support get/set/unset StoragePolicy
> ----------------------------------------------
>
> Key: HDFS-8630
> URL: https://issues.apache.org/jira/browse/HDFS-8630
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: webhdfs
> Reporter: nijel
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-8630.001.patch, HDFS-8630.002.patch,
> HDFS-8630.003.patch, HDFS-8630.004.patch, HDFS-8630.005.patch,
> HDFS-8630.006.patch, HDFS-8630.007.patch, HDFS-8630.008.patch,
> HDFS-8630.009.patch, HDFS-8630.patch
>
>
> User can set and get the storage policy from filesystem object. Same
> operation can be allowed trough REST API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
