[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711204#comment-15711204
]
Weiwei Yang edited comment on HDFS-11156 at 12/1/16 7:50 AM:
-------------------------------------------------------------
Regarding to the jenkins job result
# The findbugs error was from a recent commit HDFS-10930, not from this patch.
# The checkstyle issues were not caused by this patch either, 1st issue was the
method too long, 2nd the code style was using nested blocks in switch-case
block.
# The 2 UT failures also not related, I have run them locally and they all
succeed. They seemed to be intermittent failures, HDFS-9599 and HDFS-11030
might be related.
I've also tested this with latest trunk code on a small cluster, both
{noformat}
http://<nn>:<port>/webhdfs/v1/tmp/test.log?op=GETFILEBLOCKLOCATIONS&length=100&offset=0
{noformat}
and
{noformat}
http://<nn>:<port>/webhdfs/v1/tmp/test.log?op=GET_BLOCK_LOCATIONS&length=100&offset=0
{noformat}
works and returned expected value. [~liuml07] Would you please help to review
the patch?
Thanks a lot.
was (Author: cheersyang):
Regarding to the jenkins job result
# The findbugs error was from a recent commit HDFS-10930, not from this patch.
# The checkstyle issues were not caused by this patch either, 1st issue was the
method too long, 2nd the code style was using nested blocks in switch-case
block.
# The 2 UT failures also not related, I have run them locally and they all
succeed. They seemed to be intermittent failures, HDFS-9599 and HDFS-11030
might be related.
Hello [~liuml07] Would you please help to review the patch ? Thanks a lot.
> Webhdfs rest api GET_BLOCK_LOCATIONS output doesn't comply with FileSystem API
> ------------------------------------------------------------------------------
>
> Key: HDFS-11156
> URL: https://issues.apache.org/jira/browse/HDFS-11156
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: webhdfs
> Affects Versions: 2.7.3
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Attachments: HDFS-11156.01.patch, HDFS-11156.02.patch,
> HDFS-11156.03.patch, HDFS-11156.04.patch, HDFS-11156.05.patch
>
>
> Following webhdfs REST API
> {code}
> http://<HOST>:<PORT>/webhdfs/v1/<PATH>?op=GET_BLOCK_LOCATIONS&offset=0&length=1
> {code}
> will get a response like
> {code}
> {
> "LocatedBlocks" : {
> "fileLength" : 1073741824,
> "isLastBlockComplete" : true,
> "isUnderConstruction" : false,
> "lastLocatedBlock" : { ... },
> "locatedBlocks" : [ {...} ]
> }
> }
> {code}
> This represents for *o.a.h.h.p.LocatedBlocks*. However according to
> *FileSystem* API,
> {code}
> public BlockLocation[] getFileBlockLocations(Path p, long start, long len)
> {code}
> clients would expect an array of BlockLocation. This mismatch should be
> fixed. Marked as Incompatible change as this will change the output of the
> GET_BLOCK_LOCATIONS API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
