SammiChen commented on HDFS-8411:

Thanks  [~rakeshr] very much for helping review the patch!  
bq. 1. Striped reading logic is used by ec worker as well as block group 
checksum logic. Could you please rephrase the java comment and description 
Very good point! the metrics are about ECWorker. checksum reconstruction should 
not be included. I will update the update to only count the bytes read in 
ECWorker case. 

item 2 & 3 will also be taken care in new patch. 
the fireBug warning is irrelevant.  
2 checkstyle warnings will be handled. The other 2 are about 
{{ecReconstructionBytesWritten}} and {{ecReconstructionBytesRead}} must be 
private, and have accessor methods. I prefer leave these two checkstyle 
warnning alone. 

> Add bytes count metrics to datanode for ECWorker
> ------------------------------------------------
>                 Key: HDFS-8411
>                 URL: https://issues.apache.org/jira/browse/HDFS-8411
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Bo
>            Assignee: SammiChen
>         Attachments: HDFS-8411-001.patch, HDFS-8411-002.patch, 
> HDFS-8411-003.patch, HDFS-8411-004.patch, HDFS-8411-005.patch, 
> HDFS-8411-006.patch
> This is a sub task of HDFS-7674. It calculates the amount of data that is 
> read from local or remote to attend decoding work, and also the amount of 
> data that is written to local or remote datanodes.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to