[ 
https://issues.apache.org/jira/browse/HDFS-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722051#comment-15722051
 ] 

Rakesh R edited comment on HDFS-11072 at 12/5/16 1:40 PM:
----------------------------------------------------------

Thanks [~Sammi] for the patch. I'm adding few thoughts, please take a look at 
it.
# Since this is not a regular ec policy which doesn't needs codec support, I'd 
prefer to use a value -1 or -128?. That way, in future, for the new EC policies 
can represent continuous numbers 4, 5 etc.
{code}public static final byte CONTINUOUS_REPLICATE_POLICY_ID = 4;{code}
# What you think about exposing a new convenient API 
{{unsetErasureCodingPolicy(dir)}} and {{-unsetPolicy <path>}} command? Also, 
just a thought to make  {{CONTINUOUS_REPLICATE_SCHEMA}} policy internal if the 
semantic of this is only for unset(going back to traditional block replication).
# In docs, could you please mention that one can change ec policy on a 
directory.


was (Author: rakeshr):
Thanks [~Sammi] for the patch. I'm adding few thoughts, please take a look at 
it.
# Since this is not a regular ec policy which needs codec support, I'd prefer 
to use a value -1 or -128?. That way, in future, for the new EC policies can 
represent continuous numbers 4, 5 etc.
{code}public static final byte CONTINUOUS_REPLICATE_POLICY_ID = 4;{code}
# What you think about exposing a new convenient API 
{{unsetErasureCodingPolicy(dir)}} and {{-unsetPolicy <path>}} command? Also, 
just a thought to make  {{CONTINUOUS_REPLICATE_SCHEMA}} policy internal if the 
semantic of this is only for unset(going back to traditional block replication).
# In docs, could you please mention that one can change ec policy on a 
directory.

> Add ability to unset and change directory EC policy
> ---------------------------------------------------
>
>                 Key: HDFS-11072
>                 URL: https://issues.apache.org/jira/browse/HDFS-11072
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Andrew Wang
>            Assignee: SammiChen
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-11072-v1.patch, HDFS-11072-v2.patch, 
> HDFS-11072-v3.patch, HDFS-11072-v4.patch
>
>
> Since the directory-level EC policy simply applies to files at create time, 
> it makes sense to make it more similar to storage policies and allow changing 
> and unsetting the policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to