[
https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726375#comment-15726375
]
Xiaoyu Yao commented on HDFS-10930:
-----------------------------------
Thanks [~arpitagarwal].
The Github PR 170 matches with patch v10, which fixed the find bugs issue with
try-with-resource.
Patch v11 just fixed two javadoc issue where the @return comments are not
complete in LocalReplica.java.
I will commit patch v11 shortly based on [~arpitagarwal]'s +1, the Jenkins
results of v10 patch and manually rerun of all the failed unit tests (all
passed locally). The 2nd checkstyle issue does not exist in latest patch. The
1st and 3nd one is not caused by this patch.
{code}
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java:513:
private int receivePacket() throws IOException {:3: Method length is 308
lines (max allowed is 150).
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java:23:import
java.io.FileDescriptor;:8: Unused import - java.io.FileDescriptor.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java:193:
BlockSender(ExtendedBlock block, long startOffset, long length,:3: Method
length is 214 lines (max allowed is 150).
{code}
> Refactor: Wrap Datanode IO related operations
> ---------------------------------------------
>
> Key: HDFS-10930
> URL: https://issues.apache.org/jira/browse/HDFS-10930
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Fix For: 3.0.0-alpha2
>
> Attachments: HDFS-10930-branch-2.00.patch,
> HDFS-10930-branch-2.001.patch, HDFS-10930.01.patch, HDFS-10930.02.patch,
> HDFS-10930.03.patch, HDFS-10930.04.patch, HDFS-10930.05.patch,
> HDFS-10930.06.patch, HDFS-10930.07.patch, HDFS-10930.08.patch,
> HDFS-10930.09.patch, HDFS-10930.10.patch, HDFS-10930.11.patch,
> HDFS-10930.barnch-2.00.patch
>
>
> Datanode IO (Disk/Network) related operations and instrumentations are
> currently spilled in many classes such as DataNode.java, BlockReceiver.java,
> BlockSender.java, FsDatasetImpl.java, FsVolumeImpl.java,
> DirectoryScanner.java, BlockScanner.java, FsDatasetAsyncDiskService.java,
> LocalReplica.java, LocalReplicaPipeline.java, Storage.java, etc.
> This ticket is opened to consolidate IO related operations for easy
> instrumentation, metrics collection, logging and trouble shooting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
