[
https://issues.apache.org/jira/browse/HDFS-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729703#comment-15729703
]
James Clampffer commented on HDFS-10796:
----------------------------------------
Tests are included in tests/hdfs_ioservice_test.cc, they just don't get picked
up by the CI scanner.
The two build warnings are due to two #pragma message blocks I have to make it
very clear that IoService multithreading will be disabled by default. I can
remove the build messages now, or wait until the underlying bugs preventing
reliable multithreaded tests runs are fixed and remove them then. Currently
looking into the failures; tried a few machines and haven't been able to
reproduce outside of the docker image.
> libhdfs++: rationalize ioservice interactions
> ---------------------------------------------
>
> Key: HDFS-10796
> URL: https://issues.apache.org/jira/browse/HDFS-10796
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Bob Hansen
> Assignee: James Clampffer
> Attachments: HDFS-10796.HDFS-8707.000.patch
>
>
> Firstly, we should be pulling the number of threads from options.io_threads
> (which should default to std::thread::hardware_concurrency()). The library
> should pass all tests always with io_threads set to 1 or to <a very high
> number>
> Secondly, we should have _a_ constructor where the consumer doesn't need to
> manage the IOService explicitly, and the FileSystemImpl should create its own
> internally.
> Since the FileSystem is defined as being for a particular user/identity,
> there is a valid use case for the consumer to be constructing many FileSystem
> instances to represent many authenticated users in the same process, but want
> to share resources (notably have a single io_service shared amongst them
> all). In this case, the consumer would want to own the IOService and pass
> the same instance to multiple FileSystem instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
