[
https://issues.apache.org/jira/browse/HDFS-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15738591#comment-15738591
]
Hadoop QA commented on HDFS-10958:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 9 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
41s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
39s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
55s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
40s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
56s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m
14s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
1m 47s{color} | {color:orange} root: The patch generated 6 new + 1158 unchanged
- 10 fixed = 1164 total (was 1168) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 5 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
57s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs generated 9 new + 0
unchanged - 0 fixed = 9 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 54s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
1s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 63m 25s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}128m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
| | new
org.apache.hadoop.hdfs.server.datanode.FileIoProvider$WrappedFileInputStream(FileIoProvider,
FsVolumeSpi, File) may fail to clean up java.io.InputStream Obligation to
clean up resource created at FileIoProvider.java:fail to clean up
java.io.InputStream Obligation to clean up resource created at
FileIoProvider.java:[line 723] is not discharged |
| | new
org.apache.hadoop.hdfs.server.datanode.FileIoProvider$WrappedFileInputStream(FileIoProvider,
FsVolumeSpi, File, FileIoProvider$1) may fail to clean up java.io.InputStream
Obligation to clean up resource created at FileIoProvider.java:may fail to
clean up java.io.InputStream Obligation to clean up resource created at
FileIoProvider.java:[line 714] is not discharged |
| | new
org.apache.hadoop.hdfs.server.datanode.FileIoProvider$WrappedFileInputStream(FileIoProvider,
FsVolumeSpi, FileDescriptor) may fail to clean up java.io.InputStream
Obligation to clean up resource created at FileIoProvider.java:fail to clean up
java.io.InputStream Obligation to clean up resource created at
FileIoProvider.java:[line 733] is not discharged |
| | new
org.apache.hadoop.hdfs.server.datanode.FileIoProvider$WrappedFileInputStream(FileIoProvider,
FsVolumeSpi, FileDescriptor, FileIoProvider$1) may fail to clean up
java.io.InputStream Obligation to clean up resource created at
FileIoProvider.java:may fail to clean up java.io.InputStream Obligation to
clean up resource created at FileIoProvider.java:[line 714] is not discharged |
| | new
org.apache.hadoop.hdfs.server.datanode.FileIoProvider$WrappedFileOutputStream(FileIoProvider,
FsVolumeSpi, File, boolean) may fail to clean up java.io.OutputStream
Obligation to clean up resource created at FileIoProvider.java:may fail to
clean up java.io.OutputStream Obligation to clean up resource created at
FileIoProvider.java:[line 799] is not discharged |
| | new
org.apache.hadoop.hdfs.server.datanode.FileIoProvider$WrappedFileOutputStream(FileIoProvider,
FsVolumeSpi, File, boolean, FileIoProvider$1) may fail to clean up
java.io.OutputStream Obligation to clean up resource created at
FileIoProvider.java:FileIoProvider$1) may fail to clean up java.io.OutputStream
Obligation to clean up resource created at FileIoProvider.java:[line 789] is
not discharged |
| | new
org.apache.hadoop.hdfs.server.datanode.FileIoProvider$WrappedFileOutputStream(FileIoProvider,
FsVolumeSpi, FileDescriptor) may fail to clean up java.io.OutputStream
Obligation to clean up resource created at FileIoProvider.java:fail to clean up
java.io.OutputStream Obligation to clean up resource created at
FileIoProvider.java:[line 809] is not discharged |
| | new
org.apache.hadoop.hdfs.server.datanode.FileIoProvider$WrappedFileOutputStream(FileIoProvider,
FsVolumeSpi, FileDescriptor, FileIoProvider$1) may fail to clean up
java.io.OutputStream Obligation to clean up resource created at
FileIoProvider.java:may fail to clean up java.io.OutputStream Obligation to
clean up resource created at FileIoProvider.java:[line 789] is not discharged |
| | Redundant nullcheck of
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsVolumeImplBuilder.fileIoProvider,
which is known to be non-null in
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsVolumeImplBuilder.build()
Redundant null check at FsVolumeImplBuilder.java:is known to be non-null in
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsVolumeImplBuilder.build()
Redundant null check at FsVolumeImplBuilder.java:[line 74] |
| Failed junit tests |
hadoop.security.token.delegation.web.TestWebDelegationToken |
| | hadoop.hdfs.TestTrashWithSecureEncryptionZones |
| | hadoop.hdfs.TestDataTransferKeepalive |
| | hadoop.hdfs.server.namenode.TestFsck |
| | hadoop.hdfs.TestSecureEncryptionZoneWithKMS |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HDFS-10958 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12842678/HDFS-10958.02.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle xml |
| uname | Linux 2d791cbf363f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18
21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 4c38f11 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/17821/artifact/patchprocess/diff-checkstyle-root.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/17821/artifact/patchprocess/whitespace-eol.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/17821/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/17821/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/17821/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/17821/testReport/ |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/17821/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Add instrumentation hooks around Datanode disk IO
> -------------------------------------------------
>
> Key: HDFS-10958
> URL: https://issues.apache.org/jira/browse/HDFS-10958
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Xiaoyu Yao
> Assignee: Arpit Agarwal
> Attachments: HDFS-10958.01.patch, HDFS-10958.02.patch
>
>
> This ticket is opened to add instrumentation hooks around Datanode disk IO
> based on refactor work from HDFS-10930.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
