[
https://issues.apache.org/jira/browse/HDFS-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742289#comment-15742289
]
Ewan Higgs commented on HDFS-11232:
-----------------------------------
{quote}Hi. Can anyone help me with the checkstyle problem? I don't know what it
means. I tested the patch in my laptop. The same error. I thought it might be
something wrong with my laptop..However...{quote}
Hadoop indentation uses 2 spaces per level and {{switch}} and {{case}}
statements should be at the same level. The whole block you edited has an
incorrect indentation since the case statements are indented. Your changed line
ends up being indented two more spaces beyond the case statement.
e.g. take a look at {{checkHaStateChange}} in the same file.
To fix this, ignore the checkstyle error as your net change in style issues is
0. Or fix the whole switch statement. I can't speak on which would be better.
I'm a fan of constant gardening; but some people might have pending patches
which could be in conflict with a largish whitespace change (shirly, patch
tools can manage this...)
> System.err should be System.out
> -------------------------------
>
> Key: HDFS-11232
> URL: https://issues.apache.org/jira/browse/HDFS-11232
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Ethan Li
> Priority: Trivial
> Fix For: 3.0.0-alpha2
>
> Attachments: HDFS-11232.001.patch
>
>
> In
> /Users/Ethan/Worksplace/IntelliJWorkspace/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java,
> System.err.println("Generating new cluster id:"); is used. I think it should
> be System.out.println(...) since this is not an error message
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
