[
https://issues.apache.org/jira/browse/HDFS-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742548#comment-15742548
]
Rakesh R commented on HDFS-11123:
---------------------------------
Thanks [~umamaheswararao] for the patch. Just two comments:
# Can we avoid adding {{blksMovementResults}} to the monitor thread if SPS is
not running.
{code}
FSNamesystem#handleHeartbeat
if (blockManager.getStoragePolicySatisfier() != null) {
blockManager.getStoragePolicySatisfier()
.handleBlocksStorageMovementResults(blksMovementResults);
}
{code}
# It would be good to add debug logs here.
{code}
+ if (sps == null || sps.isRunning()) {
+ return;
+ }
{code}
{code}
+ if (sps == null) {
+ return;
+ }
{code}
> [SPS] Make storage policy satisfier daemon work on/off dynamically
> ------------------------------------------------------------------
>
> Key: HDFS-11123
> URL: https://issues.apache.org/jira/browse/HDFS-11123
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-10285-HDFS-11123.00.patch,
> HDFS-11123-HDFS-10285-00.patch
>
>
> The idea of this task is to make SPS daemon thread to start/stop dynamically
> in Namenode process with out needing to restart complete Namenode.
> So, this will help in the case of admin wants to switch of this SPS and wants
> to run Mover tool externally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
