[
https://issues.apache.org/jira/browse/HDFS-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762653#comment-15762653
]
Arpit Agarwal commented on HDFS-10959:
--------------------------------------
A few minor comments that can be addressed in a follow up Jira or at commit
time.
# We should add timeouts to the new unit tests.
# Comment line with @Metric annotation can be removed, it looks like a disabled
metric. Thanks for the offline explanation about this.
{code}
//@Metric("metadata related operation latency quantiles")
{code}
# Just a suggestion to shorten the metrics descriptions:_data related file io
flush rate_ can just be _file io flush rate_ etc. I am fine either way though.
> Adding per disk IO statistics in DataNode.
> ------------------------------------------
>
> Key: HDFS-10959
> URL: https://issues.apache.org/jira/browse/HDFS-10959
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HDFS-10959.00.patch, HDFS-10959.01.patch,
> HDFS-10959.02.patch, HDFS-10959.03.patch
>
>
> This ticket is opened to support per disk IO statistics in DataNode based on
> HDFS-10930. The statistics added will make it easier to implement HDFS-4169
> "Add per-disk latency metrics to DataNode".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
