[
https://issues.apache.org/jira/browse/HDFS-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763141#comment-15763141
]
Rakesh R commented on HDFS-11186:
---------------------------------
Thanks [~zhouwei] for working on this. I've few comments on the patch.
# On {{StandbyException}}, mover is throwing exception. Assume a case where SPS
is deactivated. Again assume, Mover is first querying to Standby NN, what would
be the behavior?. Instead of this how about continue to the next iteration?
{code}
659 } catch (RemoteException e) {
660 IOException cause = e.unwrapRemoteException();
661 if (!(cause instanceof StandbyException)) {
662 System.err.println("Skip Standby Namenode. " +
nnc.toString());
663 continue;
664 }
665 throw e;
{code}
# IMHO, we could change the sequence of activate and deactivate calls. Make
activate {{blockManager.activateSPS();}} as the last service in
#startActiveServices() and on the other side, make deactivate
{{blockManager.deactivateSPS();}} at the beginning of #stopActiveServices().
This will help to reduce any unwanted exceptions. Probably, you can refer
{{BlockManager#activate()}} and {{BlockManager#stop()}} functions.
> [SPS]: Daemon thread of SPS should start only in Active NN
> ----------------------------------------------------------
>
> Key: HDFS-11186
> URL: https://issues.apache.org/jira/browse/HDFS-11186
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Wei Zhou
> Assignee: Wei Zhou
> Attachments: HDFS-11186-HDFS-10285.00.patch
>
>
> As discussed in [HDFS-10885
> |https://issues.apache.org/jira/browse/HDFS-10885], we need to ensure that
> SPS is started only in Active NN. This JIRA is opened for discussion and
> tracking.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
