[
https://issues.apache.org/jira/browse/HDFS-10913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763227#comment-15763227
]
Arpit Agarwal commented on HDFS-10913:
--------------------------------------
The patch looks good. A few stylistic comments on the tests but +1 on the patch
basically.
# delayOnce doesn't need to accept any parameters, right? It always injects one
delay
# typo in test case. {{deplayMs}} should be {{delayMs}}.
# Nitpick: Unnecessary downcast in verifyFaultInjectionDelayPipeline. We can
just make the parameter of type MetricsDataNodeFaultInjector.
{code}
+ MetricsDataNodeFaultInjector mdnfi =
+ (MetricsDataNodeFaultInjector) dnFaultInjector;
{code}
> Introduce fault injectors to simulate slow mirrors
> --------------------------------------------------
>
> Key: HDFS-10913
> URL: https://issues.apache.org/jira/browse/HDFS-10913
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 2.8.0
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-10913.000.patch, HDFS-10913.001.patch,
> HDFS-10913.002.patch, HDFS-10913.003.patch, HDFS-10913.004.patch,
> HDFS-10913.005.patch, HDFS-10913.006.patch, HDFS-10913.007.patch,
> HDFS-10913.008.patch, HDFS-10913.009.patch, HDFS-10913.010.patch,
> HDFS-10913.011.patch
>
>
> BlockReceiver#datanodeSlowLogThresholdMs is used as threshold to detect slow
> mirrors. BlockReceiver only writes some warning logs. In order to better test
> behaviors of slow mirrors, it necessitates introducing fault injectors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
