[
https://issues.apache.org/jira/browse/HDFS-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiao Chen updated HDFS-11275:
-----------------------------
Attachment: HDFS-11275.01.patch
Patch 1 to add the check, don't think unit test is necessary.
Manually checked output by running {{TestFSImageWithAcl}} and changed the check
to always throw: {{Invalid group entry index after binary-searching inode:
/p(16386) with featureEntries:[user:foo:r-x, group::r--]}}
> Check groupEntryIndex and throw a helpful exception on failures when removing
> ACL.
> ----------------------------------------------------------------------------------
>
> Key: HDFS-11275
> URL: https://issues.apache.org/jira/browse/HDFS-11275
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HDFS-11275.01.patch
>
>
> We only have the logs to the exception but not the metadata, so hard to
> reproduce. The log is:
> {noformat}
> ERROR org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader: Encountered
> exception on operation
> org.apache.hadoop.hdfs.server.namenode.FSEditLogOp$SetAclOp@7aad3f7d
> java.lang.IndexOutOfBoundsException: index (-4) must not be negative
> at
> com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:301)
>
> at
> com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:280)
>
> at
> com.google.common.collect.RegularImmutableList.get(RegularImmutableList.java:91)
>
> at
> org.apache.hadoop.hdfs.server.namenode.AclStorage.removeINodeAcl(AclStorage.java:267)
>
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirectory.unprotectedRemoveAcl(FSDirectory.java:2720)
>
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirectory.unprotectedSetAcl(FSDirectory.java:2737)
>
> at
> org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.applyEditLogOp(FSEditLogLoader.java:827)
>
> at
> org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadEditRecords(FSEditLogLoader.java:231)
>
> at
> org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadFSEdits(FSEditLogLoader.java:140)
>
> at org.apache.hadoop.hdfs.server.namenode.FSImage.loadEdits(FSImage.java:846)
> {noformat}
> Let's use this jira to add more information to the exception, to hopefully
> help the next reoccurrence. (Have not failed again in the past week)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
