[
https://issues.apache.org/jira/browse/HDFS-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HDFS-11281:
-----------------------------
Description:
After HDFS-10959, it added disk IO statistics and metrics in DataNode. This
metrics was defined in {{DataNodeVolumeMetrics}}. But the metric of
{{fileIoErrorRate}} was not counted in {{DataNodeVolumeMetrics}}. The relevant
codes:
{code}
public void addFileIoError(final long latency) {
totalFileIoErrors.incr();
metadataOperationRate.add(latency);
}
{code}
Here the metric {{metadataOperationRate}} should be {{fileIoErrorRate}}. Two
reasons: 1.metadataOperationRate has been counted in
{{addMetadastaOperationLatency}}. 2.{{fileIoErrorRate}} is never counted in the
class {{DataNodeVolumeMetrics}}.
was:
After HDFS-10959, The metric of fileIoErrorRate not counted in
{{DataNodeVolumeMetrics}}. The relevant codes:
{code}
public void addFileIoError(final long latency) {
totalFileIoErrors.incr();
metadataOperationRate.add(latency);
}
{code}
Here the metric {{metadataOperationRate}} should be {{fileIoErrorRate}}. Two
reasons: 1.metadataOperationRate has been counted in
{{addMetadastaOperationLatency}}. 2.{{fileIoErrorRate}} is never counted in the
class {{DataNodeVolumeMetrics}}.
> The metric of fileIoErrorRate not counted in DataNodeVolumeMetrics
> ------------------------------------------------------------------
>
> Key: HDFS-11281
> URL: https://issues.apache.org/jira/browse/HDFS-11281
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha2
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Minor
> Attachments: HDFS-11281.001.patch
>
>
> After HDFS-10959, it added disk IO statistics and metrics in DataNode. This
> metrics was defined in {{DataNodeVolumeMetrics}}. But the metric of
> {{fileIoErrorRate}} was not counted in {{DataNodeVolumeMetrics}}. The
> relevant codes:
> {code}
> public void addFileIoError(final long latency) {
> totalFileIoErrors.incr();
> metadataOperationRate.add(latency);
> }
> {code}
> Here the metric {{metadataOperationRate}} should be {{fileIoErrorRate}}. Two
> reasons: 1.metadataOperationRate has been counted in
> {{addMetadastaOperationLatency}}. 2.{{fileIoErrorRate}} is never counted in
> the class {{DataNodeVolumeMetrics}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
