[
https://issues.apache.org/jira/browse/HDFS-11267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784957#comment-15784957
]
Hudson commented on HDFS-11267:
-------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11055 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/11055/])
HDFS-11267. Avoid redefinition of storageDirs in NNStorage and cleanup (lei:
rev a4f66655ec22ca8c960f971f2b0cdafbd3430ad7)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockPoolSliceStorage.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceStorage.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/StorageAdapter.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java
> Avoid redefinition of storageDirs in NNStorage and cleanup its accessors in
> Storage
> -----------------------------------------------------------------------------------
>
> Key: HDFS-11267
> URL: https://issues.apache.org/jira/browse/HDFS-11267
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha1
> Reporter: Manoj Govindassamy
> Assignee: Manoj Govindassamy
> Attachments: HDFS-11267.01.patch, HDFS-11267.02.patch
>
>
> In the abstract class {{Storage}}, {{storageDirs}} is a protected variable
> and all its derived classes like {{NNStorage}}, {{JNStorage}},
> {{DataStorage}}.. are iterating over this non-thread safe variable without
> any proper locks. Any parallel modification operation like add or remove
> volume can mutate the backing storageDirs list and any iterators on this list
> around the same time can face {{ConcurrentModificationException}}. It would
> be good to make the variable private and restrict the access via getters and
> setters. Any thread safe restriction need to be done can then be placed on
> the parent class only.
> Also, {{NNStorage}} redefines parent class Storage's {{storageDirs}}, making
> it inconsistent with other derived classes. Would be cleaner if {{NNStorage}}
> can avoid re-defining it locally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
