[
https://issues.apache.org/jira/browse/HDFS-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796527#comment-15796527
]
Manoj Govindassamy edited comment on HDFS-9391 at 1/4/17 12:03 AM:
-------------------------------------------------------------------
sure, will do 1 & 2.
3.
>> For the EnteringMaintenanceNodes page, it uses maintenanceOnlyReplicas to
>> describe Blocks with no live replicas. Should we use
>> OutOfServiceOnlyReplicas?
Thanks for bringing up this [~mingma]. There are some inconsistencies even with
"Decommissioning" page and would like to get clarified on that number as well.
* HDFS-9390 updated the {{Decommissioning}} page to use
{{getOutOfServiceOnlyReplicas()}} instead of {{getDecommissionOnlyReplicas()}}
* But as part of HDFS-9390, getOutOfServiceOnlyReplicas() which got introduced,
included all Maintenance and Decommission replicas. Effectively, the page has
been showing all "out of service" replicas, even though the page name is
"Decommissioning"
Excerpts from Patch v02:
{code}
if ((liveReplicas == 0) &&
(num.decommissionedAndDecommissioning() > 0)) {
decommissionOnlyReplicas++;
}
if ((liveReplicas == 0) && (num.maintenanceReplicas() > 0)) {
maintenanceOnlyReplicas++;
}
if ((liveReplicas == 0) && (num.outOfServiceReplicas() > 0)) {
outOfServiceOnlyReplicas++;
}
{code}
* So, what should "Decommissioning" page actually show ? In the patch v02
uploaded here, I made this page to include decommission related replicas only.
And, not all out of service replicas.
* Now coming to "Entering Maintenance" page, what exact replicas should be
included here ? If we show up "OutOfServiceOnlyReplicas" then it will include
all decommissioning related replicas as well. So, I am using
"maintenanceOnlyReplicas" for this page. Do, you still believe showing all
"OutOfServiceOnlyReplicas" would be better here ? Please let me know.
was (Author: manojg):
>> For the EnteringMaintenanceNodes page, it uses maintenanceOnlyReplicas to
>> describe Blocks with no live replicas. Should we use
>> OutOfServiceOnlyReplicas?
Thanks for bringing up this [~mingma]. There are some inconsistencies even with
"Decommissioning" page and would like to get clarified on that number as well.
* HDFS-9390 updated the {{Decommissioning}} page to use
{{getOutOfServiceOnlyReplicas()}} instead of {{getDecommissionOnlyReplicas()}}
* But as part of HDFS-9390, getOutOfServiceOnlyReplicas() which got introduced
included all Maintenance and Decommission replicas. Effectively, the page has
been showing all "out of service" replicas, even though the page name is
"Decommissioning"
Excerpts from Patch v02:
{code}
if ((liveReplicas == 0) &&
(num.decommissionedAndDecommissioning() > 0)) {
decommissionOnlyReplicas++;
}
if ((liveReplicas == 0) && (num.maintenanceReplicas() > 0)) {
maintenanceOnlyReplicas++;
}
if ((liveReplicas == 0) && (num.outOfServiceReplicas() > 0)) {
outOfServiceOnlyReplicas++;
}
{code}
* So, what should "Decommissioning" page actually show ? In the patch v02
uploaded here, I made this page to include decommission related replicas only.
And, not all out of service replicas.
* Now coming to "Entering Maintenance" page, what exact replicas should be
included here ? If we show up "OutOfServiceOnlyReplicas" then it will include
all decommissioning related replicas as well. So, I am using
"maintenanceOnlyReplicas" for this page. Do, you still believe showing all
"OutOfServiceOnlyReplicas" would be better here ?
> Update webUI/JMX to display maintenance state info
> --------------------------------------------------
>
> Key: HDFS-9391
> URL: https://issues.apache.org/jira/browse/HDFS-9391
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.0-alpha1
> Reporter: Ming Ma
> Assignee: Manoj Govindassamy
> Attachments: HDFS-9391-MaintenanceMode-WebUI.pdf, HDFS-9391.01.patch,
> HDFS-9391.02.patch, Maintenance webUI.png
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
