[
https://issues.apache.org/jira/browse/HDFS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028318#comment-13028318
]
Ivan Kelly commented on HDFS-1799:
----------------------------------
{quote}
This point makes sense to me, which is why I proposed the API that fixes this
issue:
https://issues.apache.org/jira/browse/HDFS-1799?focusedCommentId=13027159&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13027159
Does that seem like a fair compromise?
{quote}
I like that design a lot better. JournalManager is more of a factory in this
design. I'd rename setBufferCapacity to setOutputBufferCapacity, or remove it
completely at let the value that be read from configuration.
How will you do divert/revert with this? Or will you jump directly to
LogSegments?
> Refactor log rolling and filename management out of FSEditLog
> -------------------------------------------------------------
>
> Key: HDFS-1799
> URL: https://issues.apache.org/jira/browse/HDFS-1799
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: 0001-Added-state-management-to-FSEditLog.patch,
> 0002-Standardised-error-pattern.patch,
> 0003-Add-JournalFactory-and-move-divert-revert-out-of-FSE.patch,
> HDFS-1799-all.diff, hdfs-1799.txt, hdfs-1799.txt, hdfs-1799.txt, hdfs-1799.txt
>
>
> This is somewhat similar to HDFS-1580, but less ambitious. While that JIRA
> focuses on pluggability, this task is simply the minimum needed for HDFS-1073:
> - Refactor the filename-specific code for rolling, diverting, and reverting
> log streams out of FSEditLog into a new class
> - Clean up the related code in FSEditLog a bit
> Notably, this JIRA is going to temporarily break the BackupNode. I plan to
> circle back on the BackupNode later on this branch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
