[ 
https://issues.apache.org/jira/browse/HDFS-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800144#comment-15800144
 ] 

Manoj Govindassamy commented on HDFS-9391:
------------------------------------------

Yes, in the example you gave both maintenanceOnlyReplicas and 
outOfServiceOnlyReplicas are incremented. I see outOfServiceOnlyReplicas as 
more of a cumulative number of both decommission and maintenance. The final 
counts would be 2 for maintenanceOnlyReplicas and 3 for 
outOfServiceOnlyReplicas. 

>> In other words, maintenanceOnlyReplicas isn't strictly "all 3 replicas are 
>> maintenance". Maybe this new definition is more desirable.

Yes, in the above example, all 3 replicas are in some sort of maintenance and 
it is ok to have EnteringMaintenance page display "OutOfServiceOnlyReplicas".

But, in an another example, where only one node is in decommission and no other 
nodes are in maintenance,
-- the Decommissioning page will rightly show 1 node in decommission. There is 
no problem with this page.
-- the EnteringMaintenance page, if we start to use the new cumulative 
"OutOfServiceOnlyReplicas", then this page also will show 1 node in maintenance 
the same one which is decommissioning.  

Hopefully you have thought about this case as well. The EnteringMaintenance 
page behavior for the second example sounds ok to you ? Please let me know.

{noformat}
          .put("maintenanceOnlyReplicas",
              node.getLeavingServiceStatus().getOutOfServiceOnlyReplicas())
{noformat}

Once this open question is resolved, will attach the new patch incorporating 
all pending changes. Thanks [~mingma].

> Update webUI/JMX to display maintenance state info
> --------------------------------------------------
>
>                 Key: HDFS-9391
>                 URL: https://issues.apache.org/jira/browse/HDFS-9391
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Ming Ma
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-9391-MaintenanceMode-WebUI.pdf, HDFS-9391.01.patch, 
> HDFS-9391.02.patch, Maintenance webUI.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to