[
https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805554#comment-15805554
]
Arpit Agarwal edited comment on HDFS-10930 at 1/6/17 10:06 PM:
---------------------------------------------------------------
The local test-patch run for branch-2 (using HDFS-10930-branch-2.002.patch)
came back clean.
| Vote | Subsystem | Runtime | Comment
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 6 new or
| | | | modified test files.
| +1 | mvninstall | 3m 25s | branch-2 passed
| +1 | compile | 0m 27s | branch-2 passed
| +1 | checkstyle | 0m 24s | branch-2 passed
| +1 | mvnsite | 0m 31s | branch-2 passed
| +1 | mvneclipse | 0m 11s | branch-2 passed
| +1 | findbugs | 0m 58s | branch-2 passed
| +1 | javadoc | 0m 38s | branch-2 passed
| +1 | mvninstall | 0m 26s | the patch passed
| +1 | compile | 0m 23s | the patch passed
| +1 | javac | 0m 23s | the patch passed
| -1 | checkstyle | 0m 20s | hadoop-hdfs-project/hadoop-hdfs: The
| | | | patch generated 3 new + 530 unchanged -
| | | | 13 fixed = 533 total (was 543)
| +1 | mvnsite | 0m 28s | the patch passed
| +1 | mvneclipse | 0m 8s | the patch passed
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | findbugs | 1m 2s | the patch passed
| +1 | javadoc | 0m 35s | the patch passed
| +1 | unit | 201m 40s | hadoop-hdfs in the patch passed.
| +1 | asflicense | 0m 12s | The patch does not generate ASF License
| | | | warnings.
| | | 212m 42s |
The checkstyle issues are existing method length warnings.
Will push this to branch-2 along with HDFS-11253 to address the earlier comment.
was (Author: arpitagarwal):
The local test-patch run for branch-2 came back clean.
| Vote | Subsystem | Runtime | Comment
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 6 new or
| | | | modified test files.
| +1 | mvninstall | 3m 25s | branch-2 passed
| +1 | compile | 0m 27s | branch-2 passed
| +1 | checkstyle | 0m 24s | branch-2 passed
| +1 | mvnsite | 0m 31s | branch-2 passed
| +1 | mvneclipse | 0m 11s | branch-2 passed
| +1 | findbugs | 0m 58s | branch-2 passed
| +1 | javadoc | 0m 38s | branch-2 passed
| +1 | mvninstall | 0m 26s | the patch passed
| +1 | compile | 0m 23s | the patch passed
| +1 | javac | 0m 23s | the patch passed
| -1 | checkstyle | 0m 20s | hadoop-hdfs-project/hadoop-hdfs: The
| | | | patch generated 3 new + 530 unchanged -
| | | | 13 fixed = 533 total (was 543)
| +1 | mvnsite | 0m 28s | the patch passed
| +1 | mvneclipse | 0m 8s | the patch passed
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | findbugs | 1m 2s | the patch passed
| +1 | javadoc | 0m 35s | the patch passed
| +1 | unit | 201m 40s | hadoop-hdfs in the patch passed.
| +1 | asflicense | 0m 12s | The patch does not generate ASF License
| | | | warnings.
| | | 212m 42s |
The checkstyle issues are existing method length warnings.
Will push this to branch-2 along with HDFS-11253 to address the earlier comment.
> Refactor: Wrap Datanode IO related operations
> ---------------------------------------------
>
> Key: HDFS-10930
> URL: https://issues.apache.org/jira/browse/HDFS-10930
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Fix For: 3.0.0-alpha2
>
> Attachments: HDFS-10930-branch-2.00.patch,
> HDFS-10930-branch-2.001.patch, HDFS-10930-branch-2.002.patch,
> HDFS-10930.01.patch, HDFS-10930.02.patch, HDFS-10930.03.patch,
> HDFS-10930.04.patch, HDFS-10930.05.patch, HDFS-10930.06.patch,
> HDFS-10930.07.patch, HDFS-10930.08.patch, HDFS-10930.09.patch,
> HDFS-10930.10.patch, HDFS-10930.11.patch, HDFS-10930.barnch-2.00.patch
>
>
> Datanode IO (Disk/Network) related operations and instrumentations are
> currently spilled in many classes such as DataNode.java, BlockReceiver.java,
> BlockSender.java, FsDatasetImpl.java, FsVolumeImpl.java,
> DirectoryScanner.java, BlockScanner.java, FsDatasetAsyncDiskService.java,
> LocalReplica.java, LocalReplicaPipeline.java, Storage.java, etc.
> This ticket is opened to consolidate IO related operations for easy
> instrumentation, metrics collection, logging and trouble shooting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
