[
https://issues.apache.org/jira/browse/HDFS-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806185#comment-15806185
]
Hadoop QA commented on HDFS-7168:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HDFS-7168 does not apply to trunk. Rebase required? Wrong Branch?
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-7168 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12671916/HDFS-7168.001.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/18090/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Use excludedNodes consistently in DFSOutputStream
> -------------------------------------------------
>
> Key: HDFS-7168
> URL: https://issues.apache.org/jira/browse/HDFS-7168
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Colin P. McCabe
> Assignee: Colin P. McCabe
> Attachments: HDFS-7168.001.patch
>
>
> We currently have two separate collections of excluded nodes in the
> {{DFSOutputStream#DataStreamer}}. One is {{DFSOutputStream#failed}}; another
> is {{DFSOutputStream#excludedNodes}}. Both of these collections just deal
> with blacklisting nodes that we have found to be bad. We should just use
> excludedNodes for both.
> We also should make this a per-DFSOutputStream variable, rather than being
> per-DataStreamer. We don't need to forget all this information whenever a
> DataStreamer is torn down. Since {{DFSOutputStream#excludedNodes}} is a
> Guava cache, nodes will expire out of it once enough time elapses, so they
> will not be permanently blacklisted.
> We should also remove {{DFSOutputStream#setTestFilename}}, since it is no
> longer needed now that we can safely rename streams that are open for write.
> And {{DFSOutputStream#getBlock}} should be synchronized.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
