[ 
https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028885#comment-13028885
 ] 

Eli Collins commented on HDFS-1889:
-----------------------------------

Hey John,

I think we need to make this change in a number of places. I think federation 
added a bunch of uses of HADOOP_HOME that should be HADOOP_HDFS_HOME:

On trunk pre-federation:
{noformat}
hdfs2 (branch-0.22)$ grep -r HADOOP_HOME bin/
bin/hdfs-config.sh:elif [ -d "${HADOOP_HOME}" ]; then
bin/hdfs-config.sh:  . "$HADOOP_HOME"/bin/hadoop-config.sh
{noformat}

On trunk:
{noformat}
hdfs2 (branch-0.22)$ c trunk
Switched to branch 'trunk'
hdfs2 (trunk)$ grep -r HADOOP_HOME bin/
bin/hdfs-config.sh:elif [ -d "${HADOOP_HOME}" ]; then
bin/hdfs-config.sh:  . "$HADOOP_HOME"/bin/hadoop-config.sh
bin/stop-dfs.sh:NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -namenodes)
bin/stop-dfs.sh:SECONDARY_NAMENODES=$($HADOOP_HOME/bin/hdfs getconf 
-secondarynamenodes 2>&-)
bin/start-dfs.sh:NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -namenodes)
bin/start-dfs.sh:SECONDARY_NAMENODES=$($HADOOP_HOME/bin/hdfs getconf 
-secondarynamenodes 2>&-)
bin/refresh-namenodes.sh:namenodes=$("$HADOOP_HOME/bin/hdfs" getconf -namenodes)
bin/refresh-namenodes.sh:  "$HADOOP_HOME/bin/hdfs" dfsadmin -refreshNodes
bin/distribute-exclude.sh:namenodes=$("$HADOOP_HOME/bin/hdfs" getconf 
-namenodes)
bin/distribute-exclude.sh:excludeFilenameRemote=$("$HADOOP_HOME/bin/hdfs" 
getconf -excludeFile)
{noformat}

> incorrect path in start/stop dfs script
> ---------------------------------------
>
>                 Key: HDFS-1889
>                 URL: https://issues.apache.org/jira/browse/HDFS-1889
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: John George
>            Assignee: John George
>         Attachments: HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to 
> HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to