[ 
https://issues.apache.org/jira/browse/HDFS-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812501#comment-15812501
 ] 

Arpit Agarwal commented on HDFS-11299:
--------------------------------------

Thank you for the updated patch [~hanishakoneru]. In addition to Xiaoyu's 
feedback, one typo in the setting name: 
dfs.datanode.enable.fileio.fault.injectio. _injectio --> injection_.

The length field is a pre-existing bug but it's a good to fix it.

> Support multiple Datanode File IO hooks
> ---------------------------------------
>
>                 Key: HDFS-11299
>                 URL: https://issues.apache.org/jira/browse/HDFS-11299
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-11299.000.patch, HDFS-11299.001.patch
>
>
> HDFS-10958 introduces instrumentation hooks around DataNode disk IO and 
> HDFS-10959 adds support for profiling hooks to expose latency statistics. 
> Instead of choosing only one hook using Config parameters, we want to add two 
> separate hooks - one for profiling and one for fault injection. The fault 
> injection hook will be useful for testing purposes. 
> This jira only introduces support for fault injection hook. The 
> implementation for that will come later on.
> Also, now Default and Counting FileIOEvents would not be needed as we can 
> control enabling the profiling and fault injection hooks using config 
> parameters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to