[
https://issues.apache.org/jira/browse/HDFS-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813468#comment-15813468
]
Andrew Wang commented on HDFS-11072:
------------------------------------
I'm almost +1, thanks for the quick rev Sammi,
* In the new shell command, we get the EC policy before unsetting to check if
there is a policy already set. {{unsetStoragePolicy}} and the Java
{{unsetECPolicy}} API don't seem to error in this case, so I think we should
just call unset without checking. This also requires a fix in the user docs. As
a general comment, I prefer to surface errors on the NN rather than in the
client code, for consistency between the Java and shell APIs.
* Nit: "unexist" -> "non-existent" in the comments in testNonExistentDir
> Add ability to unset and change directory EC policy
> ---------------------------------------------------
>
> Key: HDFS-11072
> URL: https://issues.apache.org/jira/browse/HDFS-11072
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
> Affects Versions: 3.0.0-alpha1
> Reporter: Andrew Wang
> Assignee: SammiChen
> Labels: hdfs-ec-3.0-must-do
> Attachments: HDFS-11072-v1.patch, HDFS-11072-v2.patch,
> HDFS-11072-v3.patch, HDFS-11072-v4.patch, HDFS-11072-v5.patch,
> HDFS-11072-v6.patch
>
>
> Since the directory-level EC policy simply applies to files at create time,
> it makes sense to make it more similar to storage policies and allow changing
> and unsetting the policy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
