[
https://issues.apache.org/jira/browse/HDFS-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816304#comment-15816304
]
Wei-Chiu Chuang commented on HDFS-11306:
----------------------------------------
Thanks [~yzhangal] for the review
{quote}
add a finally block and call
IOUtils.cleanup(LOG, dis);
IOUtils.cleanup(LOG, bis);
{quote}
Actually, ByteArrayInputStream.close() and DataInputStream.close() are no-op.
So this is not needed. I'll work on the other two comments soon.
> Print remaining edit logs from buffer if edit log can't be rolled.
> ------------------------------------------------------------------
>
> Key: HDFS-11306
> URL: https://issues.apache.org/jira/browse/HDFS-11306
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ha, namenode
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Attachments: HDFS-11306.001.patch
>
>
> In HDFS-10943 [~yzhangal] reported that edit log can not be rolled due to
> unexpected edit logs lingering in the buffer.
> Unable to root cause the bug, I propose that we dump the remaining edit logs
> in the buffer into namenode log, before crashing namenode. Use this new
> capability to find the ops that sneaks into the buffer unexpectedly, and
> hopefully catch the bug.
> This effort is orthogonal, but related to HDFS-11292, which adds additional
> informational logs to help debug this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
