[
https://issues.apache.org/jira/browse/HDFS-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029054#comment-13029054
]
Tsz Wo (Nicholas), SZE commented on HDFS-1890:
----------------------------------------------
Tanping, thanks for the review.
No new tests added since the changes are obvious. The failed tests are not
related to this.
> A few improvements on the LeaseRenewer.pendingCreates map
> ---------------------------------------------------------
>
> Key: HDFS-1890
> URL: https://issues.apache.org/jira/browse/HDFS-1890
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1890_20110504.patch, h1890_20110504b.patch,
> h1890_20110504c.patch
>
>
> - The class is better to be just a {{Map}} instead of a {{SortedMap}}.
> - The value type is better to be {{DFSOutputStream}} instead of
> {{OutputStream}}.
> - The variable name is better to be filesBeingWritten instead of
> pendingCreates since we have append.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
