[
https://issues.apache.org/jira/browse/HDFS-11170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819534#comment-15819534
]
Andrew Wang commented on HDFS-11170:
------------------------------------
Hi [~zhouwei], thanks for revving, haven't looked at the patch yet but one
question:
bq. If so, I found there are some difference in implementation between
create(..., final InetSocketAddress[] favoredNodes) and create(..., final
ChecksumOpt checksumOpt).
Could you expand on these differences? This is all surprising from a user
perspective, which is why I'm pushing for a single unified create call.
If these differences are there for a good reason, we need to document and
enforce mutually exclusive parameters in the builder's API so we aren't
silently dropping parameters.
> Add create API in filesystem public class to support assign parameter through
> builder
> -------------------------------------------------------------------------------------
>
> Key: HDFS-11170
> URL: https://issues.apache.org/jira/browse/HDFS-11170
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: SammiChen
> Assignee: Wei Zhou
> Attachments: HDFS-11170-00.patch, HDFS-11170-01.patch
>
>
> FileSystem class supports multiple create functions to help user create file.
> Some create functions has many parameters, it's hard for user to exactly
> remember these parameters and their orders. This task is to add builder
> based create functions to help user more easily create file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
