[
https://issues.apache.org/jira/browse/HDFS-11337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822395#comment-15822395
]
Xiaoyu Yao commented on HDFS-11337:
-----------------------------------
Thanks [~arpitagarwal] for the backport effort. The patch looks good to me
overall. I just have a few minor issues.
*BlockReceiver.java*
Line 318: change for close() was not included in the original change of
HDFS-10958 but was added
maybe from a later change. Same with line 399 and line 1033.
*ReplicaInPipeline.java*
Line 298. This was not from HDFS-10958. OK with including it.
Line 307-308: missing {{IOUtils.closeStream(crcOut);}}
*FsDatasetAsyncDiskService.java*
Line 275: different from original change HDFS-10958 below.
Do you see potential issue with the original change, e.g., null volume?
{code}
volume.getFileIoProvider().mkdirsWithExistsCheck(
volume, trashDirFile);
{code}
*FSDataSetimpl.java*
line 787-790 is from HDFS-10636, which is unrelated to HDFS-11337/HDFS-10958.
Line 1046: can we pass the ReplicaInfo (or volumeSpi) to get the
InputStream from FileIoProvider? If the change is too complicated, I'm OK with
it.
Line 1069. Same as above.
*FsVolumeImpl.java*
Line 1069-1072: good catch. I think the original change from HDFS-10958 has a
leak
for the FileInputStream returned here.
> [branch-2] Add instrumentation hooks around Datanode disk IO
> ------------------------------------------------------------
>
> Key: HDFS-11337
> URL: https://issues.apache.org/jira/browse/HDFS-11337
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Xiaoyu Yao
> Assignee: Arpit Agarwal
> Attachments: HDFS-11337-branch-2.01.patch,
> HDFS-11337-branch-2.02.patch, HDFS-11337-branch-2.03.patch,
> HDFS-11337-branch-2.04.patch
>
>
> Cloned from HDFS-10958 to verify the branch-2 backport.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
