[
https://issues.apache.org/jira/browse/HDFS-11337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal updated HDFS-11337:
---------------------------------
Attachment: HDFS-11337-branch-2.05.patch
Thanks for the very thorough review [~xyao]. v05 patch addresses your feedback
and comments below.
bq. Line 318: change for close() was not included in the original change of
HDFS-10958 but was added maybe from a later change. Same with line 399 and line
1033.
You're right. Fixed for consistency with trunk.
bq. Line 307-308: missing IOUtils.closeStream(crcOut);
Fixed.
bq. Do you see potential issue with the original change, e.g., null volume?
I checked the only caller of this function and volume can never be null so this
should be fine.
bq. line 787-790 is from HDFS-10636, which is unrelated to
HDFS-11337/HDFS-10958.
Correct, it was included to allow refactoring the function.
bq. Line 1046: can we pass the ReplicaInfo (or volumeSpi) to get the
InputStream from FileIoProvider? If the change is too complicated, I'm OK with
it. Line 1069. Same as above.
I spent a lot of time on this but the refactoring gets rather complicated due
to changes in callers. I will revisit this separately later.
bq. Line 1069-1072: good catch. I think the original change from HDFS-10958 has
a leak for the FileInputStream returned here.
This looks like a pre-existing leak and not introduced by HDFS-10958. I will
file a separate bug to fix it for trunk.
> [branch-2] Add instrumentation hooks around Datanode disk IO
> ------------------------------------------------------------
>
> Key: HDFS-11337
> URL: https://issues.apache.org/jira/browse/HDFS-11337
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Xiaoyu Yao
> Assignee: Arpit Agarwal
> Attachments: HDFS-11337-branch-2.01.patch,
> HDFS-11337-branch-2.02.patch, HDFS-11337-branch-2.03.patch,
> HDFS-11337-branch-2.04.patch, HDFS-11337-branch-2.05.patch
>
>
> Cloned from HDFS-10958 to verify the branch-2 backport.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
