[
https://issues.apache.org/jira/browse/HDFS-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823571#comment-15823571
]
Lei (Eddy) Xu commented on HDFS-11287:
--------------------------------------
Thanks [~manojg]. The patch looks good to me overall.
One nit:
{code}
protected List<StorageDirectory> storageDirs =
new CopyOnWriteArrayList<>();
{code}
We can just change {{protected}} to {{private}} here, instead of doing {{new
CopyOnWriteArrayList()}} in two different constructors.
+1 pending changes.
> Storage class member storageDirs should be private to avoid unprotected
> access by derived classes
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-11287
> URL: https://issues.apache.org/jira/browse/HDFS-11287
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha1
> Reporter: Manoj Govindassamy
> Assignee: Manoj Govindassamy
> Attachments: HDFS-11287.01.patch
>
>
> HDFS-11267 fix made the abstract class Storage.java member variable
> storageDirs a thread safe one so that all its derived classes like NNStorage,
> JNStorage, DataStorage will not face any ConcurrentModificationException when
> there are volume add/remove and listing operations running in parallel. The
> fix rebase missed out few changers to the original patch. This jira is to
> address the addendum needed for the HDFS-11267 commits.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
