[ 
https://issues.apache.org/jira/browse/HDFS-11342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HDFS-11342:
------------------------------
    Attachment: HDFS-11342.001.patch

uploaded v001 patch, using a try-with-resource syntax to close the stream after 
reading the checksum

> Fix FileInputStream leak in loadLastPartialChunkChecksum
> --------------------------------------------------------
>
>                 Key: HDFS-11342
>                 URL: https://issues.apache.org/jira/browse/HDFS-11342
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Arpit Agarwal
>            Assignee: Chen Liang
>         Attachments: HDFS-11342.001.patch
>
>
> FsVolumeImpl#loadLastPartialChunkChecksum leaks a FileInputStream here:
> {code}
>   @Override
>   public byte[] loadLastPartialChunkChecksum(
>       File blockFile, File metaFile) throws IOException {
>     // readHeader closes the temporary FileInputStream.
>     DataChecksum dcs = BlockMetadataHeader
>         .readHeader(fileIoProvider.getFileInputStream(this, metaFile))
>         .getChecksum();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to