[
https://issues.apache.org/jira/browse/HDFS-11162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832539#comment-15832539
]
Anu Engineer commented on HDFS-11162:
-------------------------------------
[~vagarychen] Thanks for the patch, Some minor comments.
in CBlockCli.java
line:182
Should we check the length of argv before accessing it. what happens if the
argv length is 1 ? Also what happens if I do cli --help ?
{noformat}
String serverIP = argv[argv.length - 2];
{noformat}
Line 201:
In create volume, can we parse the size -- instead of assuming that that it is
always in MB. I am proposing that user can say 500MB or 5GB or 8TB. so it is
easy to specify the size.
Also catch the exception and print a good error for the user if the long and
int that we are trying to parse does not work correctly ? Same comment on all
commands when we are handling the user args.
> Block Storage : add command line tool
> -------------------------------------
>
> Key: HDFS-11162
> URL: https://issues.apache.org/jira/browse/HDFS-11162
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-11162-HDFS-7240.001.patch,
> HDFS-11162-HDFS-7240.002.patch, HDFS-11162-HDFS-7240.003.patch
>
>
> The block storage service uses a client side command line tool for volume
> create/delete/info/list. This JIRA it to add this command line tool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
