[
https://issues.apache.org/jira/browse/HDFS-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836624#comment-15836624
]
Xiaobing Zhou commented on HDFS-11194:
--------------------------------------
Thanks for v5 patch. [~arpitagarwal]. Having some minor comments, otherwise
LGTM.
# there is minor diff of 'S' in AVERAGE
DFSConfigKeys.DFS_METRICS_ROLLING_AVERAGE_WINDOW_LENGTH_KEY
DFSConfigKeys.DFS_METRICS_ROLLING_AVERAGES_WINDOW_LENGTH_DEFAULT
# some check style issues
> Maintain aggregated peer performance metrics on NameNode
> --------------------------------------------------------
>
> Key: HDFS-11194
> URL: https://issues.apache.org/jira/browse/HDFS-11194
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.8.0
> Reporter: Xiaobing Zhou
> Assignee: Arpit Agarwal
> Attachments: HDFS-11194.01.patch, HDFS-11194.02.patch,
> HDFS-11194-03-04.delta, HDFS-11194.03.patch, HDFS-11194.04.patch,
> HDFS-11194.05.patch
>
>
> The metrics collected in HDFS-10917 should be reported to and aggregated on
> NameNode as part of heart beat messages. This will make is easy to expose it
> through JMX to users who are interested in them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
