[ 
https://issues.apache.org/jira/browse/HDFS-11359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840582#comment-15840582
 ] 

Andrew Wang commented on HDFS-11359:
------------------------------------

Thanks for the patch [~linyiqun]!

My few high-level comments from a little knowledge of HDFS-11259:

* Do we need two states, for "in maintenance" and also "entering maintenance"?
* Can we rename the flag to just "-maintenance" like HDFS-11259?
* Please change "enter maintenance" to "entering maintenance" for grammar

Also a side note, it looks like this might be incompatible since the default 
behavior will list maintenance state nodes too.

[~eddyxu] seems similar to HDFS-11259, want to review this too?

> DFSAdmin report command supports displaying maintenance state datanodes
> -----------------------------------------------------------------------
>
>                 Key: HDFS-11359
>                 URL: https://issues.apache.org/jira/browse/HDFS-11359
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Minor
>         Attachments: HDFS-11359.001.patch
>
>
> The datanode's maintenance state info can be showed in webUI/JMX. But it 
> can't be displayed via CLI. This JIRA will improve on this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to