[
https://issues.apache.org/jira/browse/HDFS-11370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847847#comment-15847847
]
Jing Zhao commented on HDFS-11370:
----------------------------------
Thanks for the discussion, [~manojg] and [~tasanuma0829]. I agree it's better
to achieve thread safe for the new {{getExpectedStorageLocationsIterator}}. But
currently almost all block related classes, from Block to BlockInfo to
BlockUnderConstructionFeature, does not provide thread-safe guarantee and
depend on external mechanism such as the FSNamesystem lock for protection. So I
do not think we need to address this issue here, but maybe we can add a java
doc for {{getExpectedStorageLocationsIterator}} explaining that the method is
not thread-safe by itself.
> Optimize NamenodeFsck#getReplicaInfo
> ------------------------------------
>
> Key: HDFS-11370
> URL: https://issues.apache.org/jira/browse/HDFS-11370
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Minor
> Attachments: HDFS-11370.1.patch, HDFS-11370.2.patch,
> HDFS-11370.3.patch, HDFS-11370.4.patch, HDFS-11370.5.patch
>
>
> We can optimize the logic of calculating the number of storages in
> {{NamenodeFsck#getReplicaInfo}}. This is a follow-on task of HDFS-11124.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
