[ 
https://issues.apache.org/jira/browse/HDFS-11385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849874#comment-15849874
 ] 

Yiqun Lin commented on HDFS-11385:
----------------------------------

+1 for this idea. Attach a simple patch for this. Only one comment from me: Is 
this should be an incompatible change? Because it will run ok when meeting the 
failure.


> DistCp CopyCommitter should issue warning instead of throw exception when 
> failed to delete file.
> ------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-11385
>                 URL: https://issues.apache.org/jira/browse/HDFS-11385
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: distcp
>            Reporter: Yongjun Zhang
>            Assignee: Yiqun Lin
>         Attachments: HDFS-11385.001.patch
>
>
> CopyCommiter#deleteMissing(Configuration conf) does the following in a loop 
> for all files that need to be deleted:
> {code}
>         if (result) {
>           LOG.info("Deleted " + trgtFileStatus.getPath() + " - Missing at 
> source");
>           deletedEntries++;
>         } else {
>           throw new IOException("Unable to delete " + 
> trgtFileStatus.getPath());
>         }
> {code}
> If for some reason there is a failure to delete a file, then an exception is 
> thrown and no other files will be deleted.
> It seems more reasonable to issue a warning here instead of throw an 
> exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to