[
https://issues.apache.org/jira/browse/HDFS-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862321#comment-15862321
]
Surendra Singh Lilhore commented on HDFS-11401:
-----------------------------------------------
Thanks [~cheersyang] for the patch
I have few comments :
1. In {{Dispatcher.java}}, I think we should log one warn message for pinned
block. we can do something like this
{code}
if (e instanceof BlockPinningException) {
........
LOG.warn("Skipping pinned block " + reportedBlock.getBlock() + " to
move ");
return;
} else {
LOG.warn("Failed to move " + this, e);
}
{code}
2.
{code}
- LOG.info(msg);
+ LOG.debug(msg);
{code}
{code}
+ errMsg = "opReplaceBlock " + block + " received exception " + ioe;
+ LOG.debug(errMsg);
{code}
Here check {{LOG.isDebugEnabled()}} before logging debug log.
> Reduce verbosity of logs with favored nodes and block pinning enabled
> ---------------------------------------------------------------------
>
> Key: HDFS-11401
> URL: https://issues.apache.org/jira/browse/HDFS-11401
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover, datanode
> Affects Versions: 2.8.0
> Reporter: Thiruvel Thirumoolan
> Assignee: Weiwei Yang
> Priority: Minor
> Attachments: HDFS-11401.01.patch,
> testBalancerWithPinnedBlocks.output.txt
>
>
> I am working on enabling favored nodes for HBase (HBASE-15531). Was trying
> out what happens if favored nodes is used and HDFS balancer is enabled. Ran
> the unit test TestBalancer#testBalancerWithPinnedBlocks from branch-2.8.
> There were too many exceptions and error messages with this (output attached)
> since pinned blocks can't be moved.
> Is there any way to reduce this logging since block pinning is intentional?
> On a real cluster, this could be too much. HDFS-6133 enabled block pinning.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
