[
https://issues.apache.org/jira/browse/HDFS-11410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiao Chen updated HDFS-11410:
-----------------------------
Summary: Use the cached instance when edit logging SetAclOp, SetXAttrOp and
RemoveXAttrOp (was: Use the cached instance when edit logging XAttrOps)
> Use the cached instance when edit logging SetAclOp, SetXAttrOp and
> RemoveXAttrOp
> --------------------------------------------------------------------------------
>
> Key: HDFS-11410
> URL: https://issues.apache.org/jira/browse/HDFS-11410
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.5.0
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HDFS-11410.01.patch
>
>
> [~andrew.wang] recently had a comment on HDFS-10899:
> {quote}
> Looks like we aren't using the op cache in FSEditLog SetXAttrOp /
> RemoveXAttrOp. I think this is accidental, could you do some research?
> Particularly since we'll be doing a lot of SetXAttrOps, avoiding all that
> object allocation would be nice. This could be a separate JIRA.
> {quote}
> i.e.
> {code}
> static SetXAttrOp getInstance() {
> return new SetXAttrOp();
> }
> {code}
> v.s.
> {code}
> static AddOp getInstance(OpInstanceCache cache) {
> return (AddOp) cache.get(OP_ADD);
> }
> {code}
> Seems we should fix these non-caching usages.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
