[ https://issues.apache.org/jira/browse/HDFS-11411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869170#comment-15869170 ]
Ming Ma commented on HDFS-11411: -------------------------------- Looks good. Nits: * For {{testExpectedReplication}} case, should we move the setup() call into the function that calls startCluster? * Maybe at the end of the function, call teardown first, then setup for the next iteration. Otherwise, setup will be called twice (one from the test case setup and another one from the added explicit call) for the first iteration of test case. > Avoid OutOfMemoryError in TestMaintenanceState test runs > -------------------------------------------------------- > > Key: HDFS-11411 > URL: https://issues.apache.org/jira/browse/HDFS-11411 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Affects Versions: 3.0.0-alpha1 > Reporter: Manoj Govindassamy > Assignee: Manoj Govindassamy > Attachments: HDFS-11411.01.patch > > > TestMainteananceState test runs are seeing OutOfMemoryError issues quite > frequently now. Need to fix tests that are consuming lots of memory/threads. > {noformat} > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.hadoop.hdfs.TestMaintenanceState > Tests run: 21, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 219.479 sec > <<< FAILURE! - in org.apache.hadoop.hdfs.Te > testTransitionFromDecommissioned(org.apache.hadoop.hdfs.TestMaintenanceState) > Time elapsed: 0.64 sec <<< ERROR! > java.lang.OutOfMemoryError: unable to create new native thread > testTakeDeadNodeOutOfMaintenance(org.apache.hadoop.hdfs.TestMaintenanceState) > Time elapsed: 0.031 sec <<< ERROR! > java.lang.OutOfMemoryError: unable to create new native thread > testWithNNAndDNRestart(org.apache.hadoop.hdfs.TestMaintenanceState) Time > elapsed: 0.03 sec <<< ERROR! > java.lang.OutOfMemoryError: unable to create new native thread > testMultipleNodesMaintenance(org.apache.hadoop.hdfs.TestMaintenanceState) > Time elapsed: 60.127 sec <<< ERROR! > java.io.IOException: Problem starting http server > Results : > Tests in error: > > TestMaintenanceState.testTransitionFromDecommissioned:225->AdminStatesBaseTest.startCluster:413->AdminStatesBaseTest.s > > TestMaintenanceState.testTakeDeadNodeOutOfMaintenance:636->AdminStatesBaseTest.startCluster:413->AdminStatesBaseTest.s > > TestMaintenanceState.testWithNNAndDNRestart:692->AdminStatesBaseTest.startCluster:413->AdminStatesBaseTest.startCluste > > TestMaintenanceState.testMultipleNodesMaintenance:532->AdminStatesBaseTest.startCluster:413->AdminStatesBaseTest.start > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org